Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to v3 part #887

Merged
merged 5 commits into from
Sep 13, 2024
Merged

feat: Migrate to v3 part #887

merged 5 commits into from
Sep 13, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Aug 15, 2024

Description

another part of migration endoints
when testing, focus on account tokens listing and token events counter, nft detail
partly resolves #690

Demo

Should work without any change

Checklist:

  • I have read and followed the Contributing Guide
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

@janmichek janmichek added this to the Q3 2024 milestone Aug 27, 2024
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmichek
Copy link
Collaborator Author

janmichek commented Sep 4, 2024

@Liubov-crypto

I found some strange displaying of activities here: https://pr-887-aescan.stg.service.aepps.com/accounts/ak_fURxL4TQ3jSGvhpEzZeS7szmmNbiMwtDnUtfwRf3AqqPexXyK?type=activities

I was checking this. It's even problem in production, so not related to the change itself.
I reported this to MDW.

and here: https://pr-887-aescan-testnet.stg.service.aepps.com/accounts/ak_2iBPH7HUz3cSDVEUWiHg76MZJ6tZooVNBmmxcgVK6VV8KAE688?type=activities

I don't see any suspicious on that. Also looks the same as on production. What exactly you think its the issue?

is this correct displaying? https://pr-887-aescan-testnet.stg.service.aepps.com/tokens/ct_Sn3iTuEXniEAAiojffR5nmigCffQZwy3sNVHG6Zxof8HeNXXv?type=events

I think it's ok. Same as production. What exactly you think its the issue?

@Liubov-crypto
Copy link
Collaborator

In ad 2 there was some extra data - address in data field and amount under empty field. But now it looks good.

ad 3. Not the issue rather the view that amount, for ex 15 MDT is placing under "empty" column

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest is LGTM

@janmichek
Copy link
Collaborator Author

Thanks will be released in the second release

@janmichek janmichek merged commit 49fbb43 into develop Sep 13, 2024
5 checks passed
@janmichek janmichek deleted the migrate-to-v3-part branch September 13, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate names related endpoints to v3
2 participants